Make capacity growth parameters optional#668
Conversation
dalonsoa
left a comment
There was a problem hiding this comment.
Assuming the solver is happy with np.inf, and it seems it is considering that the tests run, this looks good to me.
May I suggest adding a quick test to check the new functionality?
The solver won't accept
I only just realised while making this PR that "inf" is an accepted value for these parameters, and it will work as intended unless all three parameters are "inf" (then the min operation will return |
|
Maybe then, in a separate PR, add some validation so if a user gives all |
Description
This is a small change to make the MaxCapacityAddition, MaxCapacityGrowth and TotalCapacityLimit parameters optional.
I've found that many users just set these to very high values so that the constraint effectively doesn't apply, but this is annoying and messy.
It's already possible to exclude this constraint by modifying
constraintsin settings.toml, but this is a bit fiddly and in general I don't think users should be modifyingconstraints(I encourage users to leave this out of their settings files so all the constraints are used by default).I think the change here to make these parameters optional is more user friendly, as all users need to do now is delete the relevant columns if they don't want to use the constraint for that sector.
Close #667
Type of change
Key checklist
$ python -m pytest$ python -m sphinx -b html docs docs/buildFurther checks